Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I aimed to further improve the robustness of the open boundary implementation. To test this, I simulated a pulse wave propagation scenario with
prescribed_pressure_in = 1000
andprescribed_pressure_out = 0
(see code below).To provoke instability, I initially removed a row of buffer particles (shown in red). The fluid particles (blue) in both simulations are evolved using EDAC without any particle shifting (i.e., no
ParticleShiftingCallback
).In the top animation, I introduced a shifting zone (black frame) specifically for the inflow boundary zone, where the PST is applied exclusively within this region. This shifting zone is independent of the global
ParticleShiftingCallback
and can be enabled or disabled for each boundary zone as needed.shifted_buffer_zone.mp4
Same setup with higher resolution and with pressure_in = 5000 and pressure_out = 0 and without any artificial provocation of instability
pulse_wave_propagation.mp4