Skip to content

Add DXF file format for load_geometry #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2025

Conversation

LasNikas
Copy link
Collaborator

@LasNikas LasNikas commented Jun 2, 2025

No description provided.

Copy link

codecov bot commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 1.92308% with 51 lines in your changes missing coverage. Please review.

Project coverage is 70.12%. Comparing base (4a74c9a) to head (a83740b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/preprocessing/geometries/io.jl 1.92% 51 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
- Coverage   70.63%   70.12%   -0.52%     
==========================================
  Files         106      106              
  Lines        6771     6822      +51     
==========================================
+ Hits         4783     4784       +1     
- Misses       1988     2038      +50     
Flag Coverage Δ
unit 70.12% <1.92%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LasNikas LasNikas marked this pull request as ready for review June 5, 2025 06:26
@LasNikas LasNikas self-assigned this Jun 5, 2025
@LasNikas LasNikas requested review from efaulhaber and svchb June 11, 2025 08:24
Copy link
Member

@efaulhaber efaulhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests, but I will add a docs page explaining how to convert SVG to DXF with Python, which will include doctests, so we can skip tests here for now.

@LasNikas LasNikas requested a review from efaulhaber June 11, 2025 16:47
@LasNikas LasNikas enabled auto-merge (squash) June 12, 2025 12:42
@svchb svchb mentioned this pull request Jun 12, 2025
@LasNikas
Copy link
Collaborator Author

/run-gpu-tests

@LasNikas LasNikas merged commit 29e7609 into trixi-framework:main Jun 12, 2025
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants