Fix Validation Setups

test/validation/validation.jl

@@ -83,4 +83,18 @@
         # Verify number of plots
         @test length(axs_edac[1].scene.plots) >= 2
     end
+
+    @trixi_testset "TGV_2D" begin
+        @trixi_test_nowarn trixi_include(@__MODULE__,
+                                         joinpath(validation_dir(),
+                                                  "taylor_green_vortex_2d",
+                                                  "validation_taylor_green_vortex_2d.jl")) [
+            r"WARNING: Method definition pressure_function.*\n",
+            r"WARNING: Method definition initial_pressure_function.*\n",
+            r"WARNING: Method definition velocity_function.*\n",
+            r"WARNING: Method definition initial_velocity_function.*\n"
+        ]
+        @test sol.retcode == ReturnCode.Success
+        @test count_rhs_allocations(sol, semi) == 0
+    end
 end

validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl

@@ -9,9 +9,9 @@ particle_spacings = [0.02, 0.01, 0.005]
 tspan = (0.0, 25.0)
 reynolds_numbers = [100.0, 1000.0, 10_000.0]
 
-interpolated_velocity(v, u, t, system) = nothing
+interpolated_velocity(system, v, u, semi, t) = nothing
 
-function interpolated_velocity(v, u, t, system::TrixiParticles.FluidSystem)
+function interpolated_velocity(system::TrixiParticles.FluidSystem, v, u, semi, t)
     if t < 24.8
         return nothing
     end

validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl

@@ -2,7 +2,8 @@ using TrixiParticles
 
 # ==========================================================================================
 # ==== Resolution
-particle_spacings = [0.02, 0.01, 0.005]
+# particle_spacings = [0.02, 0.01, 0.005]
+particle_spacings = [0.02]
 
 # ==========================================================================================
 # ==== Experiment Setup
@@ -12,10 +13,13 @@ reynolds_number = 100.0
 density_calculators = [ContinuityDensity(), SummationDensity()]
 perturb_coordinates = [false, true]
 
-function compute_l1v_error(v, u, t, system)
+function compute_l1v_error(system, v_ode, u_ode, semi, t)
     v_analytical_avg = 0.0
     v_avg = 0.0
 
+    v = TrixiParticles.wrap_v(v_ode, system, semi)
+    u = TrixiParticles.wrap_u(u_ode, system, semi)
+
     for particle in TrixiParticles.eachparticle(system)
         position = TrixiParticles.current_coords(u, system, particle)
 
@@ -32,11 +36,14 @@ function compute_l1v_error(v, u, t, system)
     return v_avg /= v_analytical_avg
 end
 
-function compute_l1p_error(v, u, t, system)
+function compute_l1p_error(system, v_ode, u_ode, semi, t)
     p_max_exact = 0.0
 
     L1p = 0.0
 
+    v = TrixiParticles.wrap_v(v_ode, system, semi)
+    u = TrixiParticles.wrap_u(u_ode, system, semi)
+
     for particle in TrixiParticles.eachparticle(system)
         position = TrixiParticles.current_coords(u, system, particle)
 
@@ -57,8 +64,8 @@ end
 
 # The pressure plotted in the paper is the difference of the local pressure minus
 # the average of the pressure of all particles.
-function diff_p_loc_p_avg(v, u, t, system)
-    p_avg_tot = avg_pressure(v, u, t, system)
+function diff_p_loc_p_avg(system, v, u, semi, t)
+    p_avg_tot = avg_pressure(system, v, u, semi, t)
 
     return v[end, :] .- p_avg_tot
 end
@@ -74,7 +81,7 @@ for density_calculator in density_calculators, perturbation in perturb_coordinat
     output_directory = joinpath("out_tgv", name_density_calculator * name_perturbation,
                                 wcsph ? "wcsph" : "edac",
                                 "validation_run_taylor_green_vortex_2d_nparticles_$(n_particles_xy)x$(n_particles_xy)")
-    saving_callback = SolutionSavingCallback(dt=0.02,
+    saving_callback = SolutionSavingCallback(dt=0.1,
                                              output_directory=output_directory,
                                              p_avg=diff_p_loc_p_avg)