-
Notifications
You must be signed in to change notification settings - Fork 15
Split fluid and TLSPH time integration to allow for TLSPH substeps #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
efaulhaber
wants to merge
15
commits into
trixi-framework:main
Choose a base branch
from
efaulhaber:split-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 70.43% 69.28% -1.16%
==========================================
Files 106 107 +1
Lines 6867 6996 +129
==========================================
+ Hits 4837 4847 +10
- Misses 2030 2149 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With high tensile modulus, TLSPH typically requires much smaller time steps than the fluid solver. The vast majority of particles are typically fluid particles, so allowing larger fluid time steps by decoupling the TLSPH time integration greatly improves performance.
Here are benchmarks using
RDPK3SpFSAL35
with adaptive time stepping for both the fluid and the solid.I simulated an elastic plate in a fluid channel in 2D. Flexural rigidity is constant, which means a thinner plate must be stiffer to obtain the same flexural rigidity. A higher resolution is also required for a thinner plate, which drastically increases runtime for thin plates.
The table shows time steps and runtime for 1s of simulation time. The last column shows the percentage of total runtime taken by the TLSPH time integration sub-steps. The benchmarks were run on a 72-core Nvidia Grace ARM CPU.
I would like to simulate a carbon fiber plate, which has a realistic thickness of 0.5-1mm and a modulus of 1.4e11. It is clear from this table that this will be impossible without split integration (400d vs 34h runtime for a plate that is still too thick).
For such a problem, we get a 300x speedup just with the standard configuration. We can use 450x larger time steps for the fluid in the last row. We can definitely speed this up even more by using specialized time integration for TLSPH, maybe even implicit time integration. This is all trivial with this PR.