IISPH (Masterarbeit Noah)

[noahstruschka]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 11.32812% with 227 lines in your changes missing coverage. Please review.

Project coverage is 68.43%. Comparing base (114a57b) to head (c007f16).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...chemes/fluid/implicit_incompressible_sph/system.jl	11.60%	198 Missing ⚠️
...c/schemes/fluid/implicit_incompressible_sph/rhs.jl	0.00%	18 Missing ⚠️
src/general/semidiscretization.jl	28.57%	5 Missing ⚠️
test/systems/iisph_system.jl	0.00%	5 Missing ⚠️
src/io/write_vtk.jl	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
- Coverage   70.60%   68.43%   -2.17%     
==========================================
  Files         106      109       +3     
  Lines        6769     7023     +254     
==========================================
+ Hits         4779     4806      +27     
- Misses       1990     2217     +227     

Flag	Coverage Δ
unit	68.43% <11.32%> (-2.17%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[efaulhaber]

I haven't looked at the docs and system.jl yet. I will do that in the next review to keep the reviews small. Please first incorporate these changes.

Also, please resolve open conversations after implementing the changes.

[efaulhaber]

Please resolve conversations after implementing the changes. And please fix the tests.

[efaulhaber]

Review of the first half of system.jl.

[efaulhaber]

I think all of these are the default. You only need this:

Suggested change

	function initial_smoothing_length(system::ImplicitIncompressibleSPHSystem, ::Nothing)
	system.smoothing_length
	end
	function smoothing_length(system::ImplicitIncompressibleSPHSystem, particle)
	return system.smoothing_length
	end
	@inline each_moving_particle(system::ImplicitIncompressibleSPHSystem) = Base.OneTo(n_moving_particles(system))
	@inline active_coordinates(u,
	system::ImplicitIncompressibleSPHSystem) = current_coordinates(u,
	system)
	@inline active_particles(system::ImplicitIncompressibleSPHSystem) = eachparticle(system)
	@inline function surface_tension_model(system::ImplicitIncompressibleSPHSystem)
	return nothing
	end
	@inline function active_coordinates(u, system::ImplicitIncompressibleSPHSystem)
	# No buffer -> `nothing`
	return active_coordinates(u, system, nothing)
	end

[noahstruschka]

We need them because the default return "system.cache.smoothing_length", but we do not have a cache.

[noahstruschka]

Or they are using the buffer, that we also don't have in IISPH