-
Notifications
You must be signed in to change notification settings - Fork 127
Add support for AMDGPU #2486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for AMDGPU #2486
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
===========================================
+ Coverage 79.36% 94.73% +15.37%
===========================================
Files 509 510 +1
Lines 42069 42113 +44
===========================================
+ Hits 33387 39895 +6508
+ Misses 8682 2218 -6464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will leave a review requesting changes so that nobody accidentally merges this PR.
Could you please bring back the code re-added in this PR? It seems to be gone in the GitHub web interface. |
Reverts #2485