-
Notifications
You must be signed in to change notification settings - Fork 127
Add package extension for Makie #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
aab4250
Add package extension for Makie
sloede ac5c2df
Add Makie to the [extras] section to make it work for Julia v1.8
sloede c6ab6ad
Fix typo
sloede ef4b6c3
Apply suggestions from code review
sloede 52ddac3
Update Project.toml
sloede a40327f
Move Makie-specific code to package extension file
sloede c07a410
Merge branch 'main' into msl/makie-pkg-extension
sloede 5738a72
Unconditionally export `iplot`, `iplot!`
sloede b004f83
fix export list
ranocha e3327d8
Add missing `using`
sloede 6d6f7bf
Merge branch 'msl/makie-pkg-extension' of github.com:trixi-framework/…
sloede 13db81d
Use more stuff from Trixi
sloede ec4450b
Extend coverage tracking to package extensions
sloede f8b32aa
Merge branch 'main' into msl/makie-pkg-extension
ranocha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Package extension for adding Makie-based features to Trixi.jl | ||
module TrixiMakieExt | ||
|
||
# Required for visualization code | ||
using Makie: Makie, GeometryBasics | ||
|
||
# Use all exported symbols to avoid having to rewrite `recipes_makie.jl` | ||
using Trixi | ||
|
||
# Use additional symbols that are not exported | ||
using Trixi: PlotData2DTriangulated, TrixiODESolution, PlotDataSeries, ScalarData, @muladd | ||
|
||
# Import functions such that they can be extended with new methods | ||
import Trixi: iplot, iplot! | ||
|
||
include("../src/visualization/recipes_makie.jl") | ||
ranocha marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.