Skip to content

build: Convert vLLM index url ARGS into docker secrets #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 21, 2025

Conversation

nv-tusharma
Copy link
Contributor

@nv-tusharma nv-tusharma commented May 9, 2025

What does the PR do?

This PR converts the build arguments used for internal vLLM into secrets.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

  • build.py

  • CI Pipeline ID:
    #28811183

Caveats:

Background

  • Better practice for dealing with repo URL variables.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@nv-tusharma nv-tusharma marked this pull request as ready for review May 21, 2025 21:24
@nv-tusharma nv-tusharma merged commit 550f64b into main May 21, 2025
3 checks passed
@nv-tusharma nv-tusharma deleted the tusharma/fix-vllm-secrets branch May 21, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants