Skip to content

build: Integrate to use PA and GAP assets if available #8155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 29, 2025

Conversation

pvijayakrish
Copy link
Contributor

What does the PR do?

Reuse the PA build assets if available.

Expected behavior:

  • When TRITON_PERF_ANALYZER_BUILD=0, the build expects PA assets to be available in the path specified by TRITON_PA_REPO_SUBDIR.
  • By default, TRITON_PERF_ANALYZER_BUILD=1, in which case PA is built from source.

Ref: ticket 718.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

else \
ls /workspace/perf_analyzer/ && \
tar -xzf /workspace/perf_analyzer/perf_analyzer*.tar.gz -C /workspace/install/bin && \
echo "Perf Analyzer binaries was extracted and not build" && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: built not build

Copy link
Contributor

@nv-kmcgill53 nv-kmcgill53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is likely a better structure for these changes, but I am not seeing it right now with how the Triton Organization divided. I will talk with the Triton Tools team to understand long term plans better. I am approving this understanding that it might have to change later.

@pvijayakrish pvijayakrish merged commit 744995f into main Apr 29, 2025
3 checks passed
@pvijayakrish pvijayakrish deleted the pvijayakrish/integrate_PA branch April 29, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants