-
Notifications
You must be signed in to change notification settings - Fork 1.6k
build: Integrate to use PA and GAP assets if available #8155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
else \ | ||
ls /workspace/perf_analyzer/ && \ | ||
tar -xzf /workspace/perf_analyzer/perf_analyzer*.tar.gz -C /workspace/install/bin && \ | ||
echo "Perf Analyzer binaries was extracted and not build" && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: built
not build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is likely a better structure for these changes, but I am not seeing it right now with how the Triton Organization divided. I will talk with the Triton Tools team to understand long term plans better. I am approving this understanding that it might have to change later.
What does the PR do?
Reuse the PA build assets if available.
Expected behavior:
Ref: ticket 718.
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.