Skip to content

fix: Pass raise_on_error to response iterators #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Conversation

kthui
Copy link
Contributor

@kthui kthui commented May 19, 2025

What does the PR do?

Pass the raise_on_error flag from infer functions to its response iterator.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

N/A

Where should the reviewer start?

N/A

Test plan:

N/A

Caveats:

N/A

Background

N/A

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

@kthui kthui self-assigned this May 19, 2025
@kthui kthui added the PR: fix A bug fix label May 19, 2025
@kthui kthui requested a review from Copilot May 19, 2025 19:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables error handling customization by passing the new raise_on_error flag to the response iterator in both asynchronous and synchronous inference flows.

  • Passes raise_on_error to AsyncResponseIterator.
  • Passes raise_on_error to ResponseIterator.

@kthui kthui requested review from nnshah1 and rmccorm4 May 19, 2025 19:50
@kthui kthui marked this pull request as ready for review May 19, 2025 19:50
Copy link
Contributor

@nnshah1 nnshah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kthui kthui merged commit 2acb246 into main May 19, 2025
3 checks passed
@kthui kthui deleted the jacky-py-infer-flag branch May 19, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix A bug fix
Development

Successfully merging this pull request may close these issues.

2 participants