Skip to content

Ibhosale r25.03 #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 3, 2025
Merged

Ibhosale r25.03 #432

merged 4 commits into from
Apr 3, 2025

Conversation

indrajit96
Copy link
Contributor

Remove TF and save model from Core tests for
triton-inference-server/server#8118

@indrajit96 indrajit96 requested review from mc-nv and ziqif-nv April 3, 2025 17:22
@mc-nv
Copy link
Contributor

mc-nv commented Apr 3, 2025

It doesn't include in our general functionality, isn't?

@indrajit96
Copy link
Contributor Author

indrajit96 commented Apr 3, 2025 •
edited
Loading

It doesn't include in our general functionality, isn't?

Yes it's a unit test for CORE maintained in CORE
Used by test in SERVER

CC @mc-nv

@mc-nv
Copy link
Contributor

mc-nv commented Apr 3, 2025 •
edited
Loading

It doesn't include in our general functionality, isn't?

Yes it's a unit test for CORE maintained in CORE Used by test in SERVER

CC @mc-nv

If it's for unit testing only can it be omitted for the release and merged into main instead?

@indrajit96
Copy link
Contributor Author

indrajit96 commented Apr 3, 2025 •
edited
Loading

It doesn't include in our general functionality, isn't?

Yes it's a unit test for CORE maintained in CORE Used by test in SERVER
CC @mc-nv

If it's for unit testing only can it be omitted for the release and merged into main instead?

L0_input_validation depends on it.
It will keep failing till we merge this

@mc-nv mc-nv requested a review from nv-kmcgill53 April 3, 2025 17:40
@nv-kmcgill53
Copy link
Contributor

I don't really care about credit but this is the same change I made on kmcgill-remove-tf. Approving

@mc-nv mc-nv merged commit 6f6a398 into r25.03 Apr 3, 2025
3 checks passed
@ziqif-nv
Copy link

ziqif-nv commented Apr 3, 2025

I don't really care about credit but this is the same change I made on kmcgill-remove-tf. Approving

thought @mc-nv has merged your branch @nv-kmcgill53 into r25.03

mc-nv pushed a commit that referenced this pull request Apr 4, 2025
@indrajit96 @mc-nv
Ibhosale r25.03 (#432)
e1f35a9 
* Update savemodel with onnx

* Update savemodel with onnx

* Stage changes

* Pre-commit fix
mc-nv added a commit that referenced this pull request Apr 8, 2025
@mc-nv @indrajit96
Ibhosale r25.03 (#432) (#433)
f503082 
* Update savemodel with onnx

* Update savemodel with onnx

* Stage changes

* Pre-commit fix

Co-authored-by: Indrajit Bhosale <iamindrajitb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nv-kmcgill53 nv-kmcgill53 nv-kmcgill53 approved these changes

@ziqif-nv ziqif-nv ziqif-nv approved these changes

@mc-nv mc-nv Awaiting requested review from mc-nv

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@indrajit96 @mc-nv @nv-kmcgill53 @ziqif-nv