feat: Ensemble async callback execution #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
yinggeh
force-pushed
the
yinggeh-DLIS-8163-ensemble-async-callback
branch
from
60cd9ba to
63135f6
Compare
GuanLuo
reviewed
Mar 13, 2025
ziqif-nv
reviewed
Apr 1, 2025
src/server.cc
Outdated
| #ifdef TRITON_ENABLE_ENSEMBLE | ||
| // TODO: Need to scale the thread pool size smarter, e.g. based on the | ||
| // instance_group count of composing models. | ||
| ensemble_cb_pool_.reset(new triton::common::ThreadPool(16u)); |
There was a problem hiding this comment.
any reason to use 16u as the magic number?
There was a problem hiding this comment.
It was based on experiments. Thread pool with size 8 generally yields highest throughput. I think we can use 8 for now and increase if necessary.
ziqif-nv
approved these changes
Apr 3, 2025
11 tasks
dmitry-tokarev-nv
added a commit
that referenced
this pull request
Apr 30, 2025
This reverts commit 56e97eb.
dmitry-tokarev-nv
added a commit
that referenced
this pull request
May 1, 2025
dmitry-tokarev-nv
added a commit
that referenced
this pull request
May 1, 2025
dmitry-tokarev-nv
added a commit
that referenced
this pull request
May 1, 2025
yinggeh
added a commit
that referenced
this pull request
May 14, 2025
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Reduce e2e latency in ensemble model by executing callbacks asynchronously at the end of each ensemble step.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/common#133
Where should the reviewer start?
Test plan:
L0_simple_ensemble
25280555
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)