Add gcs.auth-type configuration
#26681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've restored compatibility mode for |
losipiuk
reviewed
Sep 22, 2025
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Outdated
Show resolved
Hide resolved
chenjian2664
changed the title
gcs.use-access-token with gcs.auth-type configurationgcs.auth-type configuration
wendigo
reviewed
Sep 23, 2025
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
gcs-auth-type
branch
from
19ece4c to
4e57b84
Compare
chenjian2664
force-pushed
the
gcs-auth-type
branch
2 times, most recently
from
d0906b4 to
4682564
Compare
martint
reviewed
Oct 3, 2025
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 6, 2025
lib/trino-filesystem-gcs/src/main/java/io/trino/filesystem/gcs/GcsFileSystemConfig.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 6, 2025
lib/trino-filesystem-gcs/src/test/java/io/trino/filesystem/gcs/TestGcsFileSystemConfig.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
gcs-auth-type
branch
from
5512447 to
e198e0d
Compare
This makes it easier to add new GCS authentication types in the future. The commit also deprecate `gcs.use-access-token` Co-Authored-By: Mateusz "Serafin" Gajewski <66972+wendigo@users.noreply.github.com> Co-Authored-By: Łukasz Osipiuk <lukasz@osipiuk.net>
chenjian2664
force-pushed
the
gcs-auth-type
branch
from
e198e0d to
fd6f63a
Compare
|
@wendigo PTAL |
|
I'm not sure why we separated PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add new GCS authentication types in the future
also deprecated
gcs.use-access-tokenDescription
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: