Allow specifying list of allowed retry policies #26628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Sep 13, 2025
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
87b4663 to
1f8b8b2
Compare
wendigo
approved these changes
Sep 14, 2025
martint
requested changes
Sep 14, 2025
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
1f8b8b2 to
793971c
Compare
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
793971c to
a05d8f9
Compare
|
@martint please drop the "CR" when you are around. |
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
a05d8f9 to
3ce6743
Compare
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
3ce6743 to
7d88575
Compare
raunaqmorarka
approved these changes
Sep 15, 2025
martint
reviewed
Oct 3, 2025
core/trino-main/src/main/java/io/trino/execution/QueryManagerConfig.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
7d88575 to
97badc4
Compare
martint
approved these changes
Oct 6, 2025
| return this; | ||
| } | ||
|
|
||
| @AssertTrue(message = "Selected retry-policy not present in retry-policy.allowed list") |
There was a problem hiding this comment.
"Selected retry policy not present in..."
losipiuk
force-pushed
the
lukaszos/explicitly-specify-if-exchange-c-e2b3cc
branch
from
97badc4 to
5a75dc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I most cases it is better if single cluster only runs queries with specific retry policy matching cluster configuration.
This PR adds new configuration property
allowed-retry-policiesso this can be enforced.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: