Add Teradata connector #26574

sc250072 · 2025-09-07T15:55:57Z

Description

This PR introduces the Teradata connector, enabling Trino to
query and interact with Teradata data sources.

Key additions:

Implements the Teradata connector SPI with support for:
• Connection setup
• Schema retrieval
• SQL pushdown support
• Data type mapping
Adds integration tests against a Teradata ClearScape Analytics™ Experience instance to verify
connection, query execution, and result mapping.
Updates documentation under connectors to include usage
examples and configuration options.
This connector extends Trino’s ecosystem to support Teradata users, allowing them
to leverage Trino’s distributed query engine for federated queries.

Additional context and related issues

The Teradata connector module has both unit tests and integration tests.
The integration tests require access to a Teradata ClearScape Analytics™ Experience.
You can follow the steps below to run the integration tests locally.

Prerequisites

1. Create a new ClearScape Analytics™ Experience account

If you don't already have one, sign up at:

Teradata ClearScape Analytics™ Experience

2. Login

Sign in with your new account at:

ClearScape Analytics™ Experience Login

3. Collect the API Token

Use the Copy API Token button in the UI to retrieve your token.

4. Define the following environment variables

⚠️ Note: The Teradata database password must be at least 8 characters long.

export CLEARSCAPE_TOKEN=<API Token>
export CLEARSCAPE_PASSWORD=<Password for Teradata database (min 8 chars)>

Running Integration Tests

Once the environment variables are set, run the integration tests with:

⚠️ Note: Run the following command from the Trino parent directory.

./mvnw clean install -pl :trino-teradata

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Connectors
* Add Teradata connector. ({issue}`<issue-number-if-any>`)

…no dev server

Implements the Teradata connector SPI with support for: • Connection setup • Schema retrieval • SQL pushdown support • Data type mapping Adds integration tests against a Teradata ClearScape Analytics™ Experience instance to verify connection, query execution, and result mapping. Updates documentation under connectors to include usage examples and configuration options. This connector extends Trino’s ecosystem to support Teradata users, allowing them to leverage Trino’s distributed query engine for federated queries.

cla-bot · 2025-09-07T15:56:01Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr · 2025-09-09T00:26:32Z

The integration tests require access to a Teradata ClearScape Analytics™ Experience.

Is it free to use? Otherwise, who's responsible for CI expenses?

Removed not required tests

cla-bot · 2025-09-09T02:24:07Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

sc250072 · 2025-09-09T02:25:44Z

The integration tests require access to a Teradata ClearScape Analytics™ Experience.

Is it free to use? Otherwise, who's responsible for CI expenses?

It is free of use.

cla-bot · 2025-09-09T03:04:36Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Fixed github error prone check issues

cla-bot · 2025-09-09T05:16:56Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

chenjian2664 · 2025-09-11T02:11:14Z

Could you add a test that overrides BaseConnectorTest?

sc250072 · 2025-09-11T06:32:40Z

Could you add a test that overrides BaseConnectorTest?

https://github.com/trinodb/trino/pull/26574/files#diff-b3eb8fb41d01a2646e4f9dd43103edcdedf1140acbbadcd0cc5fd5d3377dbd5cR62 we have already added TeradataJdbcConnectorTest, which extends BaseJdbcConnectorTest, and in turn extends BaseConnectorTest.

cla-bot · 2025-09-12T16:33:36Z

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

ebyhr · 2025-09-13T01:36:13Z

docs/src/main/sphinx/connector.md

 Snowflake       <connector/snowflake>
 SQL Server      <connector/sqlserver>
 System          <connector/system>
+Teradata        <connector/teradata>


Please update ci.yml so we can run tests on CI. You can ask maintainers to add secrets to this repository in Slack.

ebyhr · 2025-09-13T01:36:39Z

docs/src/main/sphinx/connector/teradata.md

+<img src="../_static/img/teradata.png" class="connector-logo">
+```
+
+The Teradata connector allows querying and creating tables in an external Teradata database.


Wrap at 80 characters. Same for other places.

addressed in new PR #26731

ebyhr · 2025-09-13T01:37:57Z

docs/src/main/sphinx/connector/teradata.md

+    - `TINYINT`
+    - `TINYINT`
+    -
+


Remove redundant empty lines and fix indentation:

* - Teradata type - Trino type - Notes * - `TINYINT` - `TINYINT` - ...

addressed in new PR #26731

ebyhr · 2025-09-13T01:38:42Z

plugin/trino-teradata/pom.xml

+    <parent>
+        <groupId>io.trino</groupId>
+        <artifactId>trino-root</artifactId>
+        <version>476</version>


Change to 477-SNAPSHOT.

Changed to 478-SNAPSHOT as per latest code of trino core

ebyhr · 2025-09-13T01:39:27Z

plugin/trino-teradata/pom.xml

+    <packaging>trino-plugin</packaging>
+    <name>${project.artifactId}</name>
+    <description>Trino - Teradata connector</description>
+


Enable compiler fail warnings:

<properties> <air.compiler.fail-warnings>true</air.compiler.fail-warnings> </properties>

addressed in new PR #26731

ebyhr · 2025-09-13T01:47:49Z

plugin/trino-teradata/src/test/java/io/trino/plugin/integration/TeradataJdbcConnectorTest.java

+    public void testNumericAggregationPushdown()
+    {
+        if (!this.hasBehavior(TestingConnectorBehavior.SUPPORTS_AGGREGATION_PUSHDOWN)) {
+            Assertions.assertThat(this.query("SELECT min(nationkey) FROM nation")).isNotFullyPushedDown(AggregationNode.class);


Static import assertThat method.

addressed in new PR #26731

ebyhr · 2025-09-13T01:48:09Z

plugin/trino-teradata/src/test/java/io/trino/plugin/integration/TeradataJdbcConnectorTest.java

+    {
+        if (!this.hasBehavior(TestingConnectorBehavior.SUPPORTS_AGGREGATION_PUSHDOWN)) {
+            Assertions.assertThat(this.query("SELECT min(nationkey) FROM nation")).isNotFullyPushedDown(AggregationNode.class);
+            Assertions.assertThat(this.query("SELECT max(nationkey) FROM nation")).isNotFullyPushedDown(AggregationNode.class);


Remove redundant this..

addressed in new PR #26731

ebyhr · 2025-09-13T01:48:31Z

plugin/trino-teradata/src/test/java/io/trino/plugin/integration/TeradataJdbcConnectorTest.java

+
+        tableName = "test_ctas" + randomNameSuffix();
+        assertExplainAnalyze("EXPLAIN ANALYZE CREATE TABLE " + tableName + " AS SELECT name FROM nation");
+        assertQuery("SELECT * from " + tableName, "SELECT name FROM nation");


Use assertThat(query(...)) instead.

addressed in new PR #26731

ebyhr · 2025-09-13T01:49:02Z

...in/trino-teradata/src/test/java/io/trino/plugin/integration/TestTeradataJDBCTypeMapping.java

+import static io.trino.type.JsonType.JSON;
+import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
+
+public class TestTeradataJDBCTypeMapping


Rename to TestTeradataTypeMapping.

Also, please follow our test guideline. https://trino.io/docs/current/develop/tests.html#conventions-and-recommendations

Test classes should be defined as package-private and final.

Test methods should be defined as package-private.

addressed in new PR #26731

ebyhr · 2025-09-13T01:50:43Z

...in/trino-teradata/src/test/java/io/trino/plugin/integration/TestTeradataJDBCTypeMapping.java

+    @Test
+    public void testByteint()
+    {
+        SqlDataTypeTest.create().addRoundTrip("byteint", "0", TINYINT, "CAST(0 AS TINYINT)").addRoundTrip("byteint", "127", TINYINT, "CAST(127 AS TINYINT)").addRoundTrip("byteint", "-128", TINYINT, "CAST(-128 AS TINYINT)").addRoundTrip("byteint", "null", TINYINT, "CAST(null AS TINYINT)").execute(getQueryRunner(), teradataJDBCCreateAndInsert("byteint"));


Wrap per round trip:

SqlDataTypeTest.create() .addRoundTrip("byteint", "0", TINYINT, "CAST(0 AS TINYINT)") .addRoundTrip("byteint", "127", TINYINT, "CAST(127 AS TINYINT)") ...

addressed in #26731

…entModule

sc250072 added 7 commits September 4, 2025 21:22

Initial setup

8f3ba59

Streamlined Teradata plugin, added DEW tests, and integrated with Tri…

3f1bb34

…no dev server

Update config.properties

31d76a6

Updated files with license headers

c53a1a4

Checkstyle errors resolved

49da91d

Skipping testDataMappingSmokeTest due to issue with ClearScape instance

4106e3b

github-actions bot added the docs label Sep 7, 2025

Removed not required tests

d2cd258

Removed not required tests

Fixed PR workflow reported issues

e128e28

Fixed github error prone check issues

a92fa94

Fixed github error prone check issues

Added token to JWT authentication mechanism

e4b2713

ebyhr requested changes Sep 13, 2025

View reviewed changes

Merge branch 'trinodb:master' into master

a448b10

cla-bot bot added the cla-signed label Sep 26, 2025

This was referenced Sep 28, 2025

Handled PR review comments Teradata/trino#39

Closed

addressed PR review comments of trino team Teradata/trino#40

Merged

sc250072 added 4 commits September 28, 2025 18:31

addressed PR review comments of trino team

a0b8ea7

Refactor Teradata documentation for clarity and formatting improvements

db0ee55

Fix package declaration in Region.java for consistency

f512297

Remove unused imports and variables in TeradataClient and TeradataCli…

92d4c91

…entModule

sc250072 added 4 commits September 28, 2025 19:13

Remove unused imports in TeradataClient.java

f4bf536

Remove commented-out code in TeradataClient.java

033d2e7

Add @OverRide annotations to test methods in TeradataConnectorTest.java

06bc33b

Fix formatting in TeradataClient.java by removing trailing whitespace

8dda285

sc250072 mentioned this pull request Sep 28, 2025

Add Teradata connector #26731

Open

sc250072 closed this Sep 28, 2025

Add Teradata connector #26574

Add Teradata connector #26574

Uh oh!

Conversation

sc250072 commented Sep 7, 2025

Description

Additional context and related issues

Prerequisites

1. Create a new ClearScape Analytics™ Experience account

2. Login

3. Collect the API Token

4. Define the following environment variables

Running Integration Tests

Release notes

Uh oh!

cla-bot bot commented Sep 7, 2025

Uh oh!

ebyhr commented Sep 9, 2025

Uh oh!

cla-bot bot commented Sep 9, 2025

Uh oh!

sc250072 commented Sep 9, 2025

Uh oh!

cla-bot bot commented Sep 9, 2025

Uh oh!

cla-bot bot commented Sep 9, 2025

Uh oh!

chenjian2664 commented Sep 11, 2025

Uh oh!

sc250072 commented Sep 11, 2025

Uh oh!

cla-bot bot commented Sep 12, 2025

Uh oh!

ebyhr Sep 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

ebyhr Sep 13, 2025 •

edited

Loading