Skip to content

Conversation

cheelio
Copy link
Contributor

@cheelio cheelio commented Jun 26, 2025

Description

This pull request adds documentation for the ldap-group-provider plugin in Trino.

Additional context and related issues

Fixes #25803

Release notes

(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Jun 26, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the docs label Jun 26, 2025
Copy link

cla-bot bot commented Jun 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
Copy link

cla-bot bot commented Jun 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from d17c929 to bbf6611 Compare June 27, 2025 12:01
Copy link

cla-bot bot commented Jun 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

2 similar comments
Copy link

cla-bot bot commented Jul 3, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

cla-bot bot commented Jul 10, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from 29f197e to 89cee7d Compare July 11, 2025 05:38
@cla-bot cla-bot bot added the cla-signed label Jul 11, 2025
@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from 89cee7d to 8787b28 Compare July 11, 2025 10:29
@cheelio cheelio requested a review from OmerRaifler July 13, 2025 07:48
@cheelio cheelio assigned Praveen2112 and unassigned Praveen2112 Jul 13, 2025
@cheelio cheelio requested a review from Praveen2112 July 13, 2025 18:39
Copy link
Contributor

@gertjanal gertjanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, thanks for the documentation

Copy link

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions bot added the stale label Aug 18, 2025
@github-actions github-actions bot removed the stale label Aug 27, 2025
@cheelio cheelio closed this Sep 20, 2025
@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from 8787b28 to 4b67d9f Compare September 20, 2025 10:10
@cheelio cheelio reopened this Sep 20, 2025
@cheelio cheelio requested a review from mosabua September 20, 2025 13:14
@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from b8b7d35 to 5e7c58d Compare September 20, 2025 13:20
@cheelio cheelio force-pushed the feature/add-ldap-group-provider-docs branch from 1e47882 to 9ec0447 Compare September 24, 2025 19:53
Co-Authored-By: Manfred Moser <manfred@simpligility.ca>
@mosabua mosabua force-pushed the feature/add-ldap-group-provider-docs branch from 66601e2 to defe95a Compare September 30, 2025 20:41
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cheelio .. I applied some final tweaks and squashed. Looks good now.

@mosabua mosabua merged commit a3e23b3 into trinodb:master Sep 30, 2025
4 of 9 checks passed
@github-actions github-actions bot added this to the 478 milestone Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

LDAP-based group provider is not documented

4 participants