Ensure that createViewSession preserves the trace token #25716
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
reviewed
May 2, 2025
| @@ -661,6 +661,7 @@ public Session createViewSession(Optional<String> catalog, Optional<String> sche | |||
| .setRemoteUserAddress(getRemoteUserAddress().orElse(null)) | |||
| .setUserAgent(getUserAgent().orElse(null)) | |||
| .setClientInfo(getClientInfo().orElse(null)) | |||
| .setTraceToken(traceToken) | |||
There was a problem hiding this comment.
nit: .setTraceToken(getTraceToken())
There was a problem hiding this comment.
Thanks, I should've caught that.
huw0
force-pushed
the
preserve-trace-token-in-createviewsession
branch
from
ab8ebfe to
323b87a
Compare
ksobolew
reviewed
May 5, 2025
dain
approved these changes
May 5, 2025
|
This looks good to me, but if a test is possible, please add that. If not (or really annoying), please let us know, and one of us will merge it as is. |
|
@huw0 For testing I think we could use |
huw0
force-pushed
the
preserve-trace-token-in-createviewsession
branch
from
f82bae1 to
5e91edf
Compare
|
I've added some unit testing around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Session.createViewSessioncreates a new Session that is used when analysing views.Presently this does not pass through the trace token. This is breaking the use of views with our custom connectors which mandate that this token is populated.
Therefore this is a very simple PR to ensure that the trace token is populated in
createViewSessionif it is present on the outer session.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: