Refactor appendPath helper function to use Location#appendPath
#25609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
force-pushed
the
up_locations
branch
from
70c9b00 to
eaac0c3
Compare
Replace custom path concatenation logic with `Location#appendPath` for better consistency and to utilize the existing API. Deprecated annotation and comments are removed as part of this cleanup.
chenjian2664
force-pushed
the
up_locations
branch
from
eaac0c3 to
3d0a1d3
Compare
|
/test-with-secrets sha=e6b3590b80ce62471f92255668c1b91ba3be0e29 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/14572731944 |
|
it's a bug? |
|
#25639 already fixed the failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace custom path concatenation logic with
Location#appendPathfor better consistency and to utilize the existing API. Deprecated annotation and comments are removedas part of this cleanup.
Description
It's useful to have such utility method, so refactor instead of removing
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: