Add InfluxDB Connector #24220

k3rnL · 2024-11-21T23:48:41Z

Description

This PR introduces a new connector for InfluxDB, enabling Trino to query time-series data stored in InfluxDB. InfluxDB is a widely used time-series database but diverges from many traditional database standards, requiring a tailored approach to integration.

Additional context and related issues

I must note that most of the work was made in the past, but the PR was never finalized #15549
I have mostly only rebased the code, fixed tests and adapt the code to the new requirements.
My addition is the support for schema creation and schema/table destruction.

Release notes

( ) Release notes are required, with the following suggested text:

## Section
* Add InfluxDB connector. ({issue}`issuenumber`)

k3rnL · 2024-11-23T12:42:07Z

I'm not sure if the CI fails because of the PR's code or if the tests are flaky ?

ebyhr · 2024-11-24T05:30:54Z

ci / pt (default, suite-all-connectors-smoke, ) looks related to this change. Other failures are unrelated.

github-actions · 2024-12-16T17:03:01Z

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

github-actions · 2025-01-06T17:03:14Z

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

diegocareaga · 2025-02-17T18:47:14Z

Hey @k3rnL Do you know what happened at the end? I will be happy to collaborate with you. I see your connector really interesting. 👍

k3rnL · 2025-02-17T20:20:01Z

A lack of time mostly ! The connector is working well, the problem is to be compliant with the autonomous tests..
I was close to pass all the tests though, I think it does not need a lot of work to pass the tests.

diegocareaga · 2025-02-18T00:32:47Z

@k3rnL Could you please update the pom.xml in (plugin/trino-influxdb) with this version of trino-root snapshot? and try again? 471

471-SNAPSHOT instead of 466-SNAPSHOT and then we will see what happen

diegocareaga · 2025-02-18T05:00:38Z

Hi @k3rnL
I noticed two small things we can fix:

Your pom.xml needs a version update - just change 466-SNAPSHOT to match current version (471-SNAPSHOT). @ebyhr helped us with that but I don't know what happened - maybe a problem with cache here? becase the outdated file is only here -> /home/runner/work/trino/trino/plugin/trino-influxdb/pom.xml
There are some test failures in trino-loki module (not in your influxdb connector). Maybe we could update to the latest version and rebuild?

Really excited to try your InfluxDB connector! I'm eager to collaborate once I have access. Let me know if you need help with these fixes 😊

k3rnL · 2025-02-18T12:05:23Z

Seems @ebyhr just outperformed us 😁 Thank ! But I see that the merging is blocked because of a merge commit, but it seems this commit comes from the main branch itself. I may be mistaken, but I carefully rebased the code..

diegocareaga · 2025-02-18T13:07:06Z

@k3rnL congrats you already passed all the tests. Do you know what is the next step? if not I will ask in the slack channel

k3rnL · 2025-02-18T15:16:02Z

Perfect ! That was faster than I thought :)
Yes you may ask, thanks for your help :)

dlandz · 2025-08-04T14:57:43Z

@k3rnL are you able to get this one through?

lc-spxl · 2025-08-05T12:45:08Z

Most errors in CI are related to this

Non-resolvable parent POM for io.trino:trino-influxdb:471-SNAPSHOT: The following artifacts could not be resolved: io.trino:trino-root:pom:471-SNAPSHOT (absent): Could not find artifact io.trino:trino-root:pom:471-SNAPSHOT and 'parent.relativePath'

k3rnL · 2025-08-05T13:50:33Z

Yup, because I rebased with master, I've synced the version of trino parent in the pom of the connector and also addressed the comments of ebyhr.

There is some changes that I couldn't test on my computer, finger crossed that all the unit tests works 🤞

k3rnL · 2025-08-05T23:51:45Z

That looks better :)

dlandz · 2025-08-06T16:32:30Z

@ebyhr Is this looking better now?

ebyhr · 2025-08-06T20:38:47Z

docs/src/main/sphinx/connector/influxdb.md

+# InfluxDB connector
+
+The InfluxDB Connector allows access to [InfluxDB](https://www.influxdata.com/) data from Trino.
+This document describes how to setup the InfluxDB Connector to run SQL queries against InfluxDB.


Wrap at 80 characters. Same for other places.

ebyhr · 2025-08-06T20:39:20Z

docs/src/main/sphinx/connector/influxdb.md

+The connector maps InfluxDB types to the corresponding Trino types
+according to the following table:
+
+| InfluxDB type | Trino type | Notes |


Please use {list-table} instead.

plugin/trino-influxdb/pom.xml

ebyhr · 2025-08-06T20:59:09Z

plugin/trino-influxdb/src/test/java/io/trino/plugin/influxdb/TestInfluxConnectorTest.java

+        return createInfluxQueryRunner(server, REQUIRED_TPCH_TABLES);
+    }
+
+    @SuppressWarnings("DuplicateBranchesInSwitch")


Remove redundant suppression.

plugin/trino-influxdb/src/test/java/io/trino/plugin/influxdb/TestInfluxConnectorTest.java

plugin/trino-influxdb/src/test/java/io/trino/plugin/influxdb/TestInfluxMetadata.java

k3rnL

I changed the implementation to use the non-deprecated method and solved the reminders.

k3rnL

I've made the corrections following your comments

github-actions · 2025-09-03T17:03:13Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

k3rnL · 2025-09-04T19:24:11Z

@ebyhr Is there something more I can do ?

github-actions · 2025-09-26T17:03:15Z

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

github-actions · 2025-10-17T17:03:25Z

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

github-actions bot added the docs label Nov 21, 2024

k3rnL force-pushed the k3rnl/influxdb-connector branch 9 times, most recently from c26a3f8 to caed040 Compare November 22, 2024 22:30

k3rnL force-pushed the k3rnl/influxdb-connector branch from caed040 to 480d66d Compare November 24, 2024 21:49

github-actions bot added the stale label Dec 16, 2024

github-actions bot closed this Jan 6, 2025

k3rnL reopened this Feb 17, 2025

k3rnL force-pushed the k3rnl/influxdb-connector branch from 480d66d to 42a0cb4 Compare February 17, 2025 20:20

cla-bot bot added the cla-signed label Feb 17, 2025

ebyhr mentioned this pull request Feb 18, 2025

Influxdb connector #25053

Closed

ebyhr force-pushed the k3rnl/influxdb-connector branch from 42a0cb4 to b19ea18 Compare February 18, 2025 01:12

ebyhr force-pushed the k3rnl/influxdb-connector branch from b19ea18 to e30e1f4 Compare February 18, 2025 10:12

k3rnL reopened this Aug 5, 2025

k3rnL force-pushed the k3rnl/influxdb-connector branch from 462476d to ce212fb Compare August 5, 2025 12:13

k3rnL force-pushed the k3rnl/influxdb-connector branch from ce212fb to d08634e Compare August 5, 2025 13:47

github-actions bot removed the stale label Aug 5, 2025

k3rnL force-pushed the k3rnl/influxdb-connector branch 3 times, most recently from a105a2a to 5b531d8 Compare August 5, 2025 22:58

ebyhr reviewed Aug 6, 2025

View reviewed changes

k3rnL force-pushed the k3rnl/influxdb-connector branch from 5b531d8 to b0e8181 Compare August 12, 2025 22:54

k3rnL commented Aug 12, 2025

View reviewed changes

k3rnL force-pushed the k3rnl/influxdb-connector branch 3 times, most recently from ef05025 to 8f110cf Compare August 13, 2025 00:03

Add InfluxDB connector

8e6dfdc

k3rnL force-pushed the k3rnl/influxdb-connector branch from 8f110cf to 8e6dfdc Compare August 13, 2025 00:12

k3rnL commented Aug 13, 2025

View reviewed changes

github-actions bot added the stale label Sep 3, 2025

github-actions bot removed the stale label Sep 5, 2025

github-actions bot added the stale label Sep 26, 2025

github-actions bot closed this Oct 17, 2025

k3rnL reopened this Oct 17, 2025

Add InfluxDB Connector #24220

Are you sure you want to change the base?

Add InfluxDB Connector #24220

Uh oh!

Conversation

k3rnL commented Nov 21, 2024

Description

Additional context and related issues

Release notes

Uh oh!

k3rnL commented Nov 23, 2024

Uh oh!

ebyhr commented Nov 24, 2024

Uh oh!

github-actions bot commented Dec 16, 2024

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

diegocareaga commented Feb 17, 2025

Uh oh!

k3rnL commented Feb 17, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

k3rnL commented Feb 18, 2025

Uh oh!

diegocareaga commented Feb 18, 2025

Uh oh!

k3rnL commented Feb 18, 2025

Uh oh!

dlandz commented Aug 4, 2025

Uh oh!

lc-spxl commented Aug 5, 2025

Uh oh!

k3rnL commented Aug 5, 2025

Uh oh!

k3rnL commented Aug 5, 2025

Uh oh!

dlandz commented Aug 6, 2025

Uh oh!

ebyhr Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

ebyhr Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ebyhr Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

k3rnL left a comment

Choose a reason for hiding this comment

Uh oh!

k3rnL left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 3, 2025

Uh oh!

k3rnL commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 26, 2025

Uh oh!

github-actions bot commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

6 participants