Skip to content

Switch sphinx theme to immaterial #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

kumiDa
Copy link
Contributor

@kumiDa kumiDa commented May 12, 2025

Following package version bumps have been done in requirements.in and corresponding auto updates are done in requirements.txt

Package old_version new_version
sphinx 7.3.7 8.2.3
myst_parser 2.0.0 4.0.1
markupsafe 2.1.5 3.0.2

@cla-bot cla-bot bot added the cla-signed label May 12, 2025
@kumiDa kumiDa requested a review from wendigo May 12, 2025 19:16
@wendigo
Copy link
Contributor

wendigo commented May 12, 2025

@kumiDa can you add sphinx-immaterial so we can use the new image with trinodb/trino#25735

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumiDa kumiDa force-pushed the fix/sphinx-image-update branch from 92ed30b to 995fc2e Compare May 13, 2025 01:17
@kumiDa kumiDa force-pushed the fix/sphinx-image-update branch 3 times, most recently from ee7330b to 4cf888f Compare May 13, 2025 01:36
@kumiDa
Copy link
Contributor Author

kumiDa commented May 13, 2025

The commit title is too long. Please follow https://trino.io/development/process#pull-request-and-commit-guidelines-

@ebyhr, thanks for you review. This is addressed in 4cf888f, please review.

@kumiDa can you add sphinx-immaterial so we can use the new image with trinodb/trino#25735

@wendigo, i have incorporated the suggested changes in 4cf888f, please review.

Updates required dependencies: myst-parser, sphinx, markupsafe
@wendigo wendigo force-pushed the fix/sphinx-image-update branch from 4cf888f to 3f470e7 Compare May 13, 2025 04:12
@wendigo wendigo changed the title Update python package versions to latest versions Switch sphinx theme to immaterial May 13, 2025
@wendigo
Copy link
Contributor

wendigo commented May 13, 2025

@kumiDa I've amended commit message to reflect actual intent

@wendigo wendigo merged commit 83ab306 into trinodb:master May 13, 2025
14 checks passed
@kumiDa kumiDa deleted the fix/sphinx-image-update branch May 13, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants