Deserialize StringColumnStatisticsData, handle default value when ave… #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randgalt
reviewed
Apr 11, 2025
| if (type == SdkBytes.class) { | ||
| sdkField.set(builder, SdkBytes.fromByteArray(fieldValue.binaryValue())); | ||
| } | ||
| else if (type == StringColumnStatisticsData.class) { | ||
| System.out.println("$$$"); |
Randgalt
requested changes
Apr 11, 2025
Comment on lines
78
to
79
| else if (type == StringColumnStatisticsData.class) { | ||
| System.out.println("$$$"); |
There was a problem hiding this comment.
I removed this if clause and the tests still pass. Please update the tests so that they fail without this change.
Regardless, we should find a more general solution than special-casing a single model.
…rageLength is null
avibhstarburst
force-pushed
the
avibh/StringColumnStatisticsData_averageLength_default_value
branch
from
cc17bfb to
35fc77b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rageLength is null