fix: needsPromotion fixed in deploy github actions

[ericallam]

Summary by CodeRabbit

• Documentation

  • Added documentation outlining an update to the promotion configuration.

• Bug Fixes

  • Revised the deployment process to correctly interpret the promotion flag based on the specified option for skipping promotion.

[changeset-bot]

🦋 Changeset detected

Latest commit: 683d731

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
trigger.dev	Patch
@trigger.dev/build	Patch
@trigger.dev/core	Patch
@trigger.dev/python	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/rsc	Patch
@trigger.dev/sdk	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch
@internal/redis-worker	Patch
@internal/zod-worker	Patch
references-nextjs-realtime	Patch
@internal/testcontainers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

A new changeset markdown file has been introduced that documents a patch related to the "trigger.dev" configuration, specifically addressing the output of the "needsPromotion" GitHub action. Additionally, the deployment logic in the CLI has been adjusted by inverting the boolean assignment for the needsPromotion property based on the skipPromotion option, effectively reversing how deployment promotion is determined.

Changes

File(s)	Change Summary
.changeset/silent-squids-glow.md	New markdown file documenting a patch for trigger.dev, detailing the output of the needsPromotion action.
packages/cli-v3/src/commands/deploy.ts	Inverted the boolean logic for needsPromotion: set to true when skipPromotion is true, and vice versa.

Sequence Diagram(s)

sequenceDiagram
    participant C as CLI Command
    participant D as Deploy Logic
    participant O as Options (skipPromotion)
    participant N as needsPromotion Value

    C->>D: Execute deploy command with options
    D->>O: Check skipPromotion flag
    O-->>D: Return flag value
    D->>N: Invert flag and assign needsPromotion accordingly

Loading

Poem

Hopping through code with a joyful beat,
I'm a little rabbit, dancing on each seat.
New docs and logic make the system glow,
With inverted booleans, the deploys now flow.
Celebrate this patch — a techy, bouncy show! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5164935 and 683d731.

📒 Files selected for processing (2)

• .changeset/silent-squids-glow.md (1 hunks)
• packages/cli-v3/src/commands/deploy.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• .changeset/silent-squids-glow.md

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

packages/cli-v3/src/commands/deploy.ts (1)

504-504: Excellent fix to the needsPromotion logic.

This change correctly inverts the boolean logic for the needsPromotion GitHub Actions output. Now, when a user skips promotion during deployment (skipPromotion is true), the GitHub Actions workflow will properly understand that promotion is still needed later (needsPromotion is "true"). This aligns with the expected behavior in CI/CD pipelines where skipping immediate promotion indicates that a separate promotion step is required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.