-
-
Notifications
You must be signed in to change notification settings - Fork 725
Remove Bun version warning #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA warning about a specific Bun version requirement for the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@0x77dev is bun working for you? |
At this place https://github.com/triggerdotdev/trigger.dev/pull/1409/files it should also use the newest Bun version. It is right now difficult to work with Bun in Trigger.Dev because it is not using a new version of Bun. |
We should definitely use a more recent version and maybe make this configurable. The reason this isn't quite as simple is that when we tested newer releases recently, there were still issues once deployed on our infra. Will have to give this another spin when we get a chance. This PR is definitely not enough though - we'll have to make changes in at least the places @HansKristoffer linked, and possibly add a new runtime option. |
We decided to remove our experimental Bun support entirely. Node will be the only supported runtime on v4+. It was never well tested and there wasn't much demand in the community. Version updates became a problem due to bugs and incompatibilities, e.g. OTel and checkpoints. There were additional challenges with the node+bun image we had to use given our entry point only supports node and has to spawn bun processes. |
✅ Checklist
Changelog
Summary by CodeRabbit