Skip to content

fix(core): workaround for GC-related test issue #4870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Apr 3, 2025

The underlying issue seems to be caused by the GC not freeing the old session since it is reachable from the C stack, so the ImageBuffer lock is not dropped.

@romanz romanz self-assigned this Apr 3, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Apr 3, 2025
Copy link

github-actions bot commented Apr 3, 2025

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz romanz added core Trezor Core firmware. Runs on Trezor Model T and T2B1. tests Automated integration tests labels Apr 3, 2025
@romanz romanz requested review from mmilata and matejcik April 3, 2025 06:52
@romanz romanz marked this pull request as ready for review April 3, 2025 06:52
@matejcik
Copy link
Contributor

matejcik commented Apr 3, 2025

let's not do this, it's magic with no clear mechanism of effect that can break and reappear anywhere.
plus it appears that #4871 fixes the underlying problem

@romanz romanz closed this Apr 3, 2025
@romanz romanz deleted the romanz/prof-str branch April 3, 2025 08:32
@romanz romanz removed the status in Firmware Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. tests Automated integration tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants