Skip to content

Conversation

@hdevine825
Copy link
Contributor

@hdevine825 hdevine825 commented Jan 23, 2025

This PR…

  • Solves an issue where Osmosis fails due to a merge command after only one input.

Considerations and implementations

Uses tracking of count of land tile files to exclude the --m flag after the first file.

How to test

  1. ...
  2. ...

Pull Request Checklist

@treee111 treee111 changed the title [Fix] Osmosis fix too many --m flags [FIX] Osmosis fix too many --m flags Apr 22, 2025
@treee111
Copy link
Owner

Hi @hdevine825, I tested this PR locally. For me, the --m flag was needed even when only having one land file.
I didn't run with contour lines. Have you?

This is the error when using your version:

INFO:--------------------------------------------------------------------------------
INFO:# Merge splitted tiles with land, elevation, and sea
INFO:+ (tile 1 of 1) Coordinates: 134,88
ERROR:subprocess error output:
ERROR:Apr. 22, 2025 3:43:06 PM org.openstreetmap.osmosis.core.Osmosis run
INFORMATION: Osmosis Version 0.49.2
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Apr. 22, 2025 3:43:06 PM org.openstreetmap.osmosis.core.Osmosis run
INFORMATION: Preparing pipeline.
Apr. 22, 2025 3:43:06 PM org.openstreetmap.osmosis.tagtransform.impl.TransformLoader parseTranslation
INFORMATION: New translation: Adjust tunnel Layers
Apr. 22, 2025 3:43:06 PM org.openstreetmap.osmosis.core.Osmosis main
SCHWERWIEGEND: Execution aborted.
org.openstreetmap.osmosis.core.OsmosisRuntimeException: The following named pipes () and 1 default pipes have not been terminated with appropriate output sinks.
        at org.openstreetmap.osmosis.core.pipeline.common.Pipeline.connectTasks(Pipeline.java:96)
        at org.openstreetmap.osmosis.core.pipeline.common.Pipeline.prepare(Pipeline.java:116)
        at org.openstreetmap.osmosis.core.Osmosis.run(Osmosis.java:86)
        at org.openstreetmap.osmosis.core.Osmosis.main(Osmosis.java:37)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants