Skip to content

refactor(scanner): use new array header for stack #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

eed3si9n
Copy link
Collaborator

@eed3si9n eed3si9n commented Jul 17, 2024

Problem

@psarna wrote in #404:

Without proper alignment, UBSAN will cause the program to fail at runtime with "illegal instruction" signal.

Solution

This cherry picks scanner change 2c5c1d2 from #398.

@eed3si9n eed3si9n merged commit a13f2d1 into tree-sitter:master Jul 17, 2024
5 checks passed
@eed3si9n eed3si9n deleted the wip/array branch July 17, 2024 18:56
@amaanq
Copy link
Member

amaanq commented Aug 16, 2024

thank you for cherry picking my work @eed3si9n, I intended to make it easier to review/split it up, but didn't have time. and thanks for the NPM release too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants