Skip to content

Conversation

native-api
Copy link

…messages

(This is a PR against another PR, #49)

@native-api native-api mentioned this pull request Aug 1, 2019
@BanzaiMan
Copy link
Contributor

I'm sorry, but I don't understand the rationale for this. We control what arguments are sent to these functions, and we should be reasonably certain that the strings don't need escaping.

@native-api
Copy link
Author

native-api commented Aug 2, 2019

Some of the insertions contain user data for which we cannot be certain that it doesn't have backslashes.
For strings you control, you can be certain, but if you don't escape them, you'll have to make judgements calls on what does and doesn't need escaping. A completely unnecessary maintenance burden and a stealthy source of bugs if this changes in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants