feat(api): Implement authentication and user management #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feat/6/authentication
branch
6 times, most recently
from
7463100 to
bd6b13a
Compare
Running `composer openapi:test` would lead to `composer openapi` being called or at would do something equivalent to what the latter does. Additionally, running `composer openapi` generates the updated documentation so, if it is first run on the test before `composer openapi:test` it would never catch, when a developer has not generated documentation. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/6/authentication
branch
2 times, most recently
from
e7f1961 to
d0b5054
Compare
nfebe
commented
Nov 24, 2024
nfebe
force-pushed
the
feat/6/authentication
branch
2 times, most recently
from
d04198a to
c430ae1
Compare
aanorbel
requested changes
Nov 25, 2024
| 'last_name' => 'string|max:255', | ||
| 'username' => 'string|max:255', | ||
| 'phone' => 'string|max:255', | ||
| 'password' => 'required|string|min:8', |
There was a problem hiding this comment.
last_name, username and phone are optional.
There was a problem hiding this comment.
Was thinking of password constraints. We can change that at any time.
nfebe
force-pushed
the
feat/6/authentication
branch
from
c430ae1 to
5f46f19
Compare
…n system - Added notification service to handle email notifications. - Created GenericMail mailable for email communication with support for dynamic content. - Implemented registration, login, and forgot password functionality in AuthController. - Enhanced User model to support username and phone number for login. - Created events and listeners for user registration (UserRegisteredEvent, UserRegistered listener). - Added user seeder to populate test users (UserSeeder). - Updated migrations to include phone number and username in the users table. - Created a new migration for verification codes (create_verification_codes_table). - Added middleware to ensure requests have a JSON body (EnsureRequestBodyIsJson). - Updated Kernel.php to register the new middleware. - Added route definitions for new authentication endpoints (api.php, web.php). - Created unit and feature tests for authentication and password reset functionality. - Removed unused tests (ExampleTest.php). - Updated UserFactory to generate test users with username and phone number. - Created view for email templates (resources/views/emails/generic.blade.php). Signed-off-by: nfebe <opensource@nfebe.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
feat/6/authentication
branch
from
5f46f19 to
17b20e3
Compare
aanorbel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves trakli/trakli#6