Skip to content

style: project not formatted with either gofmt or golangci-lint #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2024
Merged

style: project not formatted with either gofmt or golangci-lint #11

merged 1 commit into from
Dec 26, 2024

Conversation

nekomeowww
Copy link
Contributor

I was doing some preparation works before opening the upcoming PRs, but I found that the source files haven't being formatted correctly either by gofmt or golangci-lint, I would recommend to integrate the "de facto" lint tool in community of Golang where mostly everyone would use it to help both lintting and formatting files.

Since I would like to reduce the overhead to review my PR, so the only one thing I have done is to format them with the default shipped gofmt:

gofmt -s -w .

Later on, when you (any traceloop or contributors) accepted the proposal of golangci-lint, then I can help to integrate one.

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is indeed missing from the CI lints

@nirga nirga merged commit c57d6db into traceloop:main Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants