Add new simple opt pass to get rid of local-to-result moves in all cases #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And as I say that it gums up the tests... |
|
OK, I think all the bugs have been fixed. Remaining expect fails are mostly noise and some rightfully removed MOVs. |
|
(forgot to mention, there's a bugfix for situations involving IsDeadAfter, cogwr and result registers in this) |
|
To clarify: This should be fine now. (but still test it yourself, 4 eyes etc etc) Also there's a bugfix in here that's been exposed by this work but is generally applicable. (also behind experimental, so no immediate end-user explosion) |
Wuerfel21
force-pushed
the
W21-opt-return-values
branch
from
64adfe2 to
999999c
Compare
|
(also just rebased it) |
Wuerfel21
force-pushed
the
W21-opt-return-values
branch
from
999999c to
cf07b9d
Compare
|
Owie ouch my pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behind experimental flag, but I think this is conceptually really safe.