Skip to content

added some unit test examples #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Oaz
Copy link

@Oaz Oaz commented Sep 9, 2017

Hello,

I might use Iris.NET for a couple of projects so I started to give it a try.

I added a unit test project with some basic tests :

  • minimalist subscribe/publish scenarios
  • server monitoring scenarios
    Please let me know if this is what you expected regarding issue Unit tests #6

One tricky question is about the unit test framework. I used NUnit which is the one I'm more familiar with.

Note that I did not added the unit test project to the solution. One reason is that I don't know how you want to organize the unit tests in the solution. The other reason is that I coded with MonoDevelop which transformed substantially the .sln file.

Regards,
Olivier

@tommasobertoni
Copy link
Owner

Hey Olivier,

I'm sorry that it took me this long to get back to you...

Thank you very much for your PR!

This is exactly what I expected regarding the issue. The choice of NUnit is ok, since I didn't have any preference regarding the test frameworks.

About the organization in the solution: the folder "Iris.NET/Tests" was created to contain the test projects. Now it contains 3 console app projects, but those are only temporary and will probably be removed. But basically, your test project should look like these.

Thank you for pointing out your choice about the IDE and the changes that it affected. I'd prefer if the .sln file didn't change from the current format.


In order to accept the PR, I'm asking you the following changes:

  • Move the test project in Iris.NET/Tests/
  • Add the test project to the solution, without changing the current .sln format

Thank you,
Tom

@tommasobertoni
Copy link
Owner

Also, if you ended up using the library, a feedback would be much appreciated! 😃

I've been using it in production for about a year, and no major problems arose. But I invite you to tell me what you think!

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants