Skip to content

Answer:1 [IN PROGRESS] #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Answer:1 [IN PROGRESS] #1312

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cacb345
feat: add <ng-content> and input() and output()
allan1989 May 8, 2025
3792054
fix(student-card): error using $implicit
allan1989 May 12, 2025
1572100
chore: challenge complete
allan1989 May 18, 2025
8b837ce
chore: create directives person & templateOutlet
allan1989 May 27, 2025
a3d9682
Revert "chore: create directives person & templateOutlet"
allan1989 May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 51 additions & 4 deletions apps/angular/1-projection/src/app/component/city-card/city-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,56 @@
import { ChangeDetectionStrategy, Component } from '@angular/core';
import { NgOptimizedImage } from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
inject,
OnInit,
} from '@angular/core';
import { CityStore } from '../../data-access/city.store';
import {
FakeHttpService,
randomCity,
} from '../../data-access/fake-http.service';
import { CardComponent, CardListDirective } from '../../ui/card/card.component';
import { ListItemComponent } from '../../ui/list-item/list-item.component';

@Component({
selector: 'app-city-card',
template: 'TODO City',
imports: [],
template: `
<app-card
(addNewItem)="addNewItem()"
[list]="cities()"
class="bg-light-blue">
<img card-header ngSrc="assets/img/city.png" width="200" height="200" />
<ng-template card-list-item let-city>
<app-list-item (deleteItem)="deleteItem(city.id)">
{{ city.country }}
</app-list-item>
</ng-template>
</app-card>
`,
imports: [
NgOptimizedImage,
CardComponent,
ListItemComponent,
CardListDirective,
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class CityCardComponent {}
export class CityCardComponent implements OnInit {
private readonly http = inject(FakeHttpService);
private readonly store = inject(CityStore);

cities = this.store.cities;

ngOnInit(): void {
this.http.fetchCities$.subscribe((t) => this.store.addAll(t));
}

addNewItem() {
this.store.addOne(randomCity());
}

deleteItem(id: number) {
this.store.deleteOne(id);
}
}
49 changes: 38 additions & 11 deletions apps/angular/1-projection/src/app/component/student-card/student-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,67 @@
import { NgOptimizedImage } from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
inject,
OnInit,
} from '@angular/core';
import { FakeHttpService } from '../../data-access/fake-http.service';
import {
FakeHttpService,
randStudent,
} from '../../data-access/fake-http.service';
import { StudentStore } from '../../data-access/student.store';
import { CardType } from '../../model/card.model';
import { CardComponent } from '../../ui/card/card.component';
import { CardComponent, CardListDirective } from '../../ui/card/card.component';
import { ListItemComponent } from '../../ui/list-item/list-item.component';

@Component({
selector: 'app-student-card',
template: `
<app-card
(addNewItem)="addNewItem()"
[list]="students()"
[type]="cardType"
customClass="bg-light-green" />
class="bg-light-green">
<img
card-header
ngSrc="assets/img/student.webp"
width="200"
height="200" />
<ng-template card-list-item let-student>
<app-list-item (deleteItem)="deleteItem(student.id)">
{{ student.firstName }}
</app-list-item>
</ng-template>
</app-card>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal is to handle all the logic in the parent. You should not input the store. Very bad practise to have a service as an input.

your html structure should look like:

  <app-card // handle input and output>
      // project image
      <ng-template [cardRow]="students()" let-student>
        <app-list-item (delete)="">
         // project content
        </app-list-item>
      </ng-template>
    </app-card>
    ```

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomalaforge Qu'est-ce que [cardRow]=students() ? Est-ce un input ? A part les variables locales, je ne vois pas d'autres attributs possibles sur un ng-template....

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En effet, ne fait pas attention a cela pour le moment,
Tu pourras l'implémenter si tu veux aller plus loin dans angular ensuite mais c'est plus avancé. c'est une directive pour typer student.

`,
styles: [
`
::ng-deep .bg-light-green {
background-color: rgba(0, 250, 0, 0.1);
.bg-light-green {
background-color: rgba(250, 0, 0, 0.1);
}
`,
],
imports: [CardComponent],
imports: [
CardComponent,
NgOptimizedImage,
CardListDirective,
ListItemComponent,
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class StudentCardComponent implements OnInit {
private http = inject(FakeHttpService);
private store = inject(StudentStore);
private readonly http = inject(FakeHttpService);
public readonly store = inject(StudentStore);

students = this.store.students;
cardType = CardType.STUDENT;

ngOnInit(): void {
this.http.fetchStudents$.subscribe((s) => this.store.addAll(s));
}

addNewItem() {
this.store.addOne(randStudent());
}

deleteItem(id: number) {
this.store.deleteOne(id);
}
}
57 changes: 45 additions & 12 deletions apps/angular/1-projection/src/app/component/teacher-card/teacher-card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,67 @@
import { Component, inject, OnInit } from '@angular/core';
import { FakeHttpService } from '../../data-access/fake-http.service';
import { NgOptimizedImage } from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
inject,
OnInit,
} from '@angular/core';
import {
FakeHttpService,
randTeacher,
} from '../../data-access/fake-http.service';
import { TeacherStore } from '../../data-access/teacher.store';
import { CardType } from '../../model/card.model';
import { CardComponent } from '../../ui/card/card.component';
import { CardComponent, CardListDirective } from '../../ui/card/card.component';
import { ListItemComponent } from '../../ui/list-item/list-item.component';

@Component({
selector: 'app-teacher-card',
template: `
<app-card
(addNewItem)="addNewItem()"
[list]="teachers()"
[type]="cardType"
customClass="bg-light-red"></app-card>
class="bg-light-red">
<img
card-header
ngSrc="assets/img/teacher.png"
width="200"
height="200" />
<ng-template card-list-item let-teacher>
<app-list-item (deleteItem)="deleteItem(teacher.id)">
{{ teacher.firstName }}
</app-list-item>
</ng-template>
</app-card>
`,
styles: [
`
::ng-deep .bg-light-red {
background-color: rgba(250, 0, 0, 0.1);
.bg-light-red {
background-color: rgba(0, 250, 0, 0.1);
}
`,
],
imports: [CardComponent],
imports: [
CardComponent,
NgOptimizedImage,
CardListDirective,
ListItemComponent,
],
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class TeacherCardComponent implements OnInit {
private http = inject(FakeHttpService);
private store = inject(TeacherStore);
private readonly http = inject(FakeHttpService);
private readonly store = inject(TeacherStore);

teachers = this.store.teachers;
cardType = CardType.TEACHER;

ngOnInit(): void {
this.http.fetchTeachers$.subscribe((t) => this.store.addAll(t));
}

addNewItem() {
this.store.addOne(randTeacher());
}

deleteItem(id: number) {
this.store.deleteOne(id);
}
}
2 changes: 1 addition & 1 deletion apps/angular/1-projection/src/app/data-access/city.store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { City } from '../model/city.model';
providedIn: 'root',
})
export class CityStore {
private cities = signal<City[]>([]);
public cities = signal<City[]>([]);

addAll(cities: City[]) {
this.cities.set(cities);
Expand Down
86 changes: 37 additions & 49 deletions apps/angular/1-projection/src/app/ui/card/card.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,46 @@
import { NgOptimizedImage } from '@angular/common';
import { Component, inject, input } from '@angular/core';
import { randStudent, randTeacher } from '../../data-access/fake-http.service';
import { StudentStore } from '../../data-access/student.store';
import { TeacherStore } from '../../data-access/teacher.store';
import { CardType } from '../../model/card.model';
import { ListItemComponent } from '../list-item/list-item.component';
import { CommonModule, NgTemplateOutlet } from '@angular/common';
import {
Component,
contentChild,
Directive,
input,
output,
TemplateRef,
} from '@angular/core';

@Directive({
selector: 'ng-template [card-list-item]',
standalone: true,
})
export class CardListDirective {}

@Component({
selector: 'app-card',
host: {
class: 'flex w-fit flex-col gap-3 rounded-md border-2 border-black p-4',
},
template: `
<div
class="flex w-fit flex-col gap-3 rounded-md border-2 border-black p-4"
[class]="customClass()">
@if (type() === CardType.TEACHER) {
<img ngSrc="assets/img/teacher.png" width="200" height="200" />
<ng-content select="[card-header]"></ng-content>
<section>
@for (item of list(); track item) {
<ng-template
[ngTemplateOutlet]="cardRow()"
[ngTemplateOutletContext]="{ $implicit: item }"></ng-template>
}
@if (type() === CardType.STUDENT) {
<img ngSrc="assets/img/student.webp" width="200" height="200" />
}

<section>
@for (item of list(); track item) {
<app-list-item
[name]="item.firstName"
[id]="item.id"
[type]="type()"></app-list-item>
}
</section>

<button
class="rounded-sm border border-blue-500 bg-blue-300 p-2"
(click)="addNewItem()">
Add
</button>
</div>
</section>
<button
class="rounded-sm border border-blue-500 bg-blue-300 p-2"
(click)="addNewItem.emit()">
Add
</button>
`,
imports: [ListItemComponent, NgOptimizedImage],
imports: [CommonModule, NgTemplateOutlet],
})
export class CardComponent {
private teacherStore = inject(TeacherStore);
private studentStore = inject(StudentStore);

readonly list = input<any[] | null>(null);
readonly type = input.required<CardType>();
export class CardComponent<T> {
readonly list = input<T[]>([]);
readonly customClass = input('');

CardType = CardType;

addNewItem() {
const type = this.type();
if (type === CardType.TEACHER) {
this.teacherStore.addOne(randTeacher());
} else if (type === CardType.STUDENT) {
this.studentStore.addOne(randStudent());
}
}
addNewItem = output();
cardRow = contentChild.required(CardListDirective, {
read: TemplateRef<{ $implicit: T }>,
});
}
28 changes: 7 additions & 21 deletions apps/angular/1-projection/src/app/ui/list-item/list-item.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,26 @@
import {
ChangeDetectionStrategy,
Component,
inject,
input,
output,
} from '@angular/core';
import { StudentStore } from '../../data-access/student.store';
import { TeacherStore } from '../../data-access/teacher.store';
import { CardType } from '../../model/card.model';

@Component({
selector: 'app-list-item',
template: `
<div class="border-grey-300 flex justify-between border px-2 py-1">
{{ name() }}
<button (click)="delete(id())">
<ng-content />
<button (click)="deleteItem.emit()">
<img class="h-5" src="assets/svg/trash.svg" />
</button>
</div>
`,
imports: [],
standalone: true,
changeDetection: ChangeDetectionStrategy.OnPush,
})
export class ListItemComponent {
private teacherStore = inject(TeacherStore);
private studentStore = inject(StudentStore);

readonly id = input.required<number>();
readonly name = input.required<string>();
readonly type = input.required<CardType>();

delete(id: number) {
const type = this.type();
if (type === CardType.TEACHER) {
this.teacherStore.deleteOne(id);
} else if (type === CardType.STUDENT) {
this.studentStore.deleteOne(id);
}
}
readonly id = input<number>();
readonly name = input<string>();
deleteItem = output<void>();
}
Loading