task: opens Id::as_u64 to clients
#7454
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows clients to observe the contents of Task IDs, with no guarantees on contents. Fixes: tokio-rs#7430
github-actions
bot
added
R-loom-current-thread
|
If maintainers would prefer this being on the |
ADD-SP
added
C-enhancement
ADD-SP
reviewed
Jul 11, 2025
There was a problem hiding this comment.
#7430 wants to expose this method for getting rid of the ugly unsafe hack of tokio-dtrace, would you mind talking about your requirements?
We currently has no enough motivation to expose a stable representation of task id.
An alternative is gating this method by tokio_unstable.
However, my feeling is that once we open up the this unstable method, it will end up being used so heavily in the observability infrastructure, leading to a lot of resistance when we try to break this interface in the future, even this is tokio_unstable.
|
Looks like the big requirement is being able to observe a task id without allocating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows clients to observe the contents of Task IDs, with no guarantees on contents.
Fixes: #7430
Motivation
Solves the ask in the referenced issue (#7430) to allow a lightweight/cheap way to see the contents of a task Id.
Solution
Simply opens
task::Id::as_u64topubinstead ofpub(crate)