Skip to content

chore(runtime): reorder metrics to be grouped by cfg-gates #7453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlizen
Copy link
Member

@jlizen jlizen commented Jul 9, 2025

Motivation

#7449 fixed the generated cfg gates in our rustdocs for runtime metrics. In the interest of reviewability, we avoided reordering the metric methods.

However this resulted in interwoven groups of cfg-gates and multiple macro declarations per each. This hurts maintainability and readability.

Solution

I reorganized the module to group all like-gated methods together.

@jlizen jlizen marked this pull request as ready for review July 9, 2025 17:46
Copy link
Member

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better splitting a huge commit into serval commit, one method, one commit. This could make the code review easier.

@ADD-SP ADD-SP added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants