Implement OptionalFromRequest
for Form
and RawForm
#3355
+83
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change enables the use of Form as an optional extractor in certain scenarios.
Solution
This PR implements
OptionalFromRequest
forForm
andRawForm
. The behavior is as follows:GET
orHEAD
requests, if there are no query parameters, the extractor will returnNone
. Otherwise, it will parse the form data using the original logic.Content-Type
header is not present, the extractor will returnNone
. Otherwise, it will parse the form data using the original logic.Additionally, the
FromRequest
implementation forRawForm
does not include a check for theHEAD
method. I believe this is a bug, asForm
andRawForm
should behave consistently. Is this understanding correct?