-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Upgrade matchit #2997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade matchit #2997
Conversation
The CI failed because of change in casing of a panic message. Otherwise looks good, let's do it. |
d4a2897
to
8295007
Compare
8295007
to
a34b73e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way you had it before, we wouldn't upgrade to 0.8.5, but with the current change we would.
I just checked that it should be fine with the PR with suffixes (or at least tests seem to pass), but users still won't be able to use the suffixes because we make some checks regarding captures like making sure that the whole path segment is captured.
So I just want to make sure that this is intended.
Wasn't intended 😅 |
Thanks, we tried the new version in #3140 but decided along with the We use precise version |
Motivation
A few patch versions have been release since 0.8.0, but the anticipated problematic change (ibraheemdev/matchit#61) has not landed yet.
Solution
Bump the version requirement.