Skip to content

Upgrade matchit #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Upgrade matchit #2997

merged 2 commits into from
Oct 21, 2024

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Oct 19, 2024

Motivation

A few patch versions have been release since 0.8.0, but the anticipated problematic change (ibraheemdev/matchit#61) has not landed yet.

Solution

Bump the version requirement.

@jplatte jplatte requested a review from mladedav October 19, 2024 20:25
@mladedav
Copy link
Collaborator

The CI failed because of change in casing of a panic message.

Otherwise looks good, let's do it.

@jplatte jplatte force-pushed the jplatte/matchit-version branch from d4a2897 to 8295007 Compare October 20, 2024 14:31
@jplatte jplatte force-pushed the jplatte/matchit-version branch from 8295007 to a34b73e Compare October 20, 2024 14:41
@jplatte jplatte changed the title Allow higher patch versions of matchit Upgrade matchit Oct 20, 2024
Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way you had it before, we wouldn't upgrade to 0.8.5, but with the current change we would.

I just checked that it should be fine with the PR with suffixes (or at least tests seem to pass), but users still won't be able to use the suffixes because we make some checks regarding captures like making sure that the whole path segment is captured.

So I just want to make sure that this is intended.

@jplatte
Copy link
Member Author

jplatte commented Oct 21, 2024

Wasn't intended 😅
I just needed to raise the minimum version because our MSRV CI job checks that tests pass with minimum versions of our dependencies.

@jplatte jplatte merged commit 7281984 into main Oct 21, 2024
18 checks passed
@jplatte jplatte deleted the jplatte/matchit-version branch October 21, 2024 08:51
@kyle-leonhard
Copy link

@jplatte heads up, the machit PR mentioned in the description was merged and released in v0.8.6

@mladedav
Copy link
Collaborator

Thanks, we tried the new version in #3140 but decided along with the matchit maintainer to wait for 0.9 instead which seems to be fairly close. See that issue, the PR linked there, and the matchit issue linked in our issue for more details.

We use precise version =0.8.4 here so the fact that it has been released is safe for axum users even if it added functionality we wouldn't be able to handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants