Skip to content

types: Add StrPath typing, fix new_session, part 2 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 26, 2025
+471 −23
Merged

types: Add StrPath typing, fix new_session, part 2 #598

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c7cc090
docs: Fix mention of non-existant type
tony May 26, 2025
a3c0316
Session.new_window: Fix `start_directory` check
tony May 26, 2025
7998363
Server(feat[new_session]): Add StrPath type support for start_directory
tony May 26, 2025
66ccd3f
Pane(feat[split,split_window]): Add StrPath type support for start_di…
tony May 26, 2025
5305b4a
Window(feat[split,split_window]): Add StrPath type support for start_…
tony May 26, 2025
12c35b3
tests(Pane.split) with start_directory parameter
tony May 26, 2025
f1b6401
tests(server) Improve `start_directory` tests for `new_session`
tony May 26, 2025
9202412
tests(session) Add `new_window` start_directory tests
tony May 26, 2025
a6d220c
tests(window[split]) Add `start_directory` tests
tony May 26, 2025
62840ed
docs(CHANGES) Note `start_directory` annotations and tests
tony May 26, 2025
905e395
tests(start_directory) Improve across multiple test files
tony May 26, 2025
8483a5b
tests(start_directory) Improve checks
tony May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libtmux/_internal/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Notes
-----
:class:`StrPath` and :class:`StrOrBytesPath` is based on `typeshed's`_.
:class:`StrPath` is based on `typeshed's`_.

.. _typeshed's: https://github.com/python/typeshed/blob/5ff32f3/stdlib/_typeshed/__init__.pyi#L176-L179
""" # E501
Expand Down
2 changes: 1 addition & 1 deletion src/libtmux/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,7 @@ def new_window(
window_args += ("-P",)

# Catch empty string and default (`None`)
if start_directory and isinstance(start_directory, str):
if start_directory:
# as of 2014-02-08 tmux 1.9-dev doesn't expand ~ in new-window -c.
start_directory = pathlib.Path(start_directory).expanduser()
window_args += (f"-c{start_directory}",)
Expand Down