Skip to content

internal/gclayout: make gclayout values constants #4947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dgryski
Copy link
Member

@dgryski dgryski commented Jul 8, 2025

The previous versions calculated at init() prevented interp from running in many cases, increasing compile times due to the increased need to revert the partially interpreted results and also increasing binary runtime because fewer optimizations had happened during interp.

@dgryski dgryski marked this pull request as draft July 8, 2025 22:23
@dgryski dgryski force-pushed the dgryski/gclayout-interp branch from 7336fb2 to 0d17fcc Compare July 9, 2025 00:16
The previous versions calculated at init() prevented `interp` from running
in many cases, increasing compile times due to the increased need to revert
the partially interpreted results and also increasing binary runtime because
fewer optimizations had happened during interp.
@dgryski
Copy link
Member Author

dgryski commented Jul 9, 2025

make wasmtest WorksForMe(tm). Not sure what's up with CI.

~/go/src/github.com/tinygo-org/tinygo $ make wasmtest
go test ./tests/wasm
ok  	github.com/tinygo-org/tinygo/tests/wasm	30.970s

@deadprogram
Copy link
Member

@deadprogram
Copy link
Member

@dgryski please rebase against lastest dev to pass CI.

Copy link
Member

@aykevl aykevl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, using constants is much better.

Not sure about AsPtr but I can't really think of a better name for the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants