Migrate to ruff #42
Migrate to ruff #42
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| playwright_stealth/properties/init.py | ✅ |
| playwright_stealth/core/init.py | ✅ |
| playwright_stealth/init.py | ✅ |
| playwright_stealth/properties/_viewport_properties.py | ✅ |
| examples/stealth_mode.py | ✅ |
| playwright_stealth/stealth.py | ✅ |
| playwright_stealth/core/_stealth_config.py | ✅ |
| playwright_stealth/properties/_properties.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Decided to share my prefs. I sort generic editor settings on the top (together with per-lang modifications) and language specific ones bellow
|
|
||
| [tool.ruff.lint] | ||
| select = ["E", "F", "I", "UP"] | ||
| ignore = ["E501"] |
There was a problem hiding this comment.
Is it a lot of warnings currently? If not I'd prefer to fix them and not ignore in the future (the lib is small enough)
There was a problem hiding this comment.
@colriot , this is a copy paste from another repo, but fix it how?
I don't want to manually format docstrings..
There was a problem hiding this comment.
Maybe there is nothing to fix at all. How many these warnings are there?
| "editor.rulers": [120], | ||
| "files.insertFinalNewline": true, | ||
| "python.analysis.typeCheckingMode": "standard", | ||
| "windsurfPyright.analysis.typeCheckingMode": "standard", | ||
| "python.testing.pytestArgs": ["tests"], |
No description provided.