Skip to content

Add stealth to tests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Add stealth to tests #24

merged 6 commits into from
Nov 15, 2024

Conversation

TinyGambe
Copy link
Contributor

@TinyGambe TinyGambe commented Nov 8, 2024

Fix e2e Tests

Added missing scripts

Screenshot 2024-11-14 at 10 50 55 AM

@TinyGambe TinyGambe marked this pull request as draft November 8, 2024 18:10
@TinyGambe TinyGambe marked this pull request as ready for review November 14, 2024 18:52
@TinyGambe TinyGambe requested a review from paveldudka November 14, 2024 18:52
Copy link
Contributor

@Zechereh Zechereh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits. But otherwise, thanks for the fix Gambe!

Comment on lines +75 to +86
utils_script = from_file("utils.js")
magic_arrays_script = from_file("generate.magic.arrays.js")

properties = Properties()
opts = json.dumps(properties.as_dict())
opts = f"const opts = {opts}"

combined_script = (
opts + "\n" + utils_script + "\n" + magic_arrays_script + "\n" + config.script
)

page.add_init_script(combined_script)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@TinyGambe TinyGambe merged commit 35ebbc0 into main Nov 15, 2024
6 checks passed
@TinyGambe TinyGambe deleted the fix-tests branch November 15, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants