Add unit tests for properties
#18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zechereh
commented
Oct 31, 2024
Comment on lines
-28
to
-36
| def _generate_vendor(self) -> str: | ||
| """Generates the vendor based on the user agent.""" | ||
|
|
||
| return random.choice(self.webgl_properties)["vendor"] | ||
|
|
||
| def _generate_renderer(self) -> str: | ||
| """Generates the renderer based on the user agent.""" | ||
|
|
||
| return random.choice(self.webgl_properties)["renderer"] |
There was a problem hiding this comment.
This approach allowed for potential mismatches of a vendor and renderer. (i.e AMD as the vendor and a NVIDIA GTX 1660 as the rendered)
Consolidated the logic into one random.choice() call to prevent this.
LMK if this was by design
paveldudka
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.