Explicitly use parameter binding to prevent generating mangled FQN pr… #32
Conversation
…ojection names because of backslash escaping i.e. prevent App\Models\Class to AppModelsClass.
Retrieving the projection also requires a whereRaw to handle the backslashes in the projection_name. The updated_at field should be used to determine the start_date as not the created_at.
|
@drsdre We have some regressions on the test with your last commit. Not sure your change will fix the problem. Thanks for your contribution! |
|
One other fix slipped into this pull request which probably should have been kept in a separate pull request. I found an issue where the start_date was set not changing when the projected record got updated. It turns out that the created_at date is used to determine the start date. When records are updated, the updated_at should be used to reflect the change and map it to the right time period. With the latest commit, I've updated the test to also set the updated_at in the test model as it normally is done also by Eloquent. This makes the test green again. |
I ran into a blocking issue where non of the time series were retrieved. It turned out that in the projection name queries the backslashes from the FQCN were interpreted as character escapes. This caused a search for App\Models\Model to become a search for AppModelsModel hence nothing got retrieved.
This patch explicitly tells eloquent to use database resolved parameter bindings. With parameter binding the database will figure out if the value should be escaped or not. The tests are still green with this change.
Probably the reason why the tests were green before had to do with Sqlite not doing character escaping whilst MariaDB/MySQL does.