Preliminary support for include(mapexpr, file)
#939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal-methodtables
…ernal-methodtables
…ernal-methodtables
In conjunction with `CodeTracking.MapFile`, this allows Revise to track changes in files that are included with `include(mapexpr, file)`. This PR supports the implementation of revisions for such files, properly applying the `mapexpr` transformation to the included file's expressions. What's missing: - Revise can't correctly populate the internal data structures needed to initiate `mapexpr` without help. The problem is that Revise only parses files that get edited, but discovering that `file2.jl` gets included from `file1.jl` via a `mapexpr` requires parsing `file1.jl`, which may not have been edited and therefore never scanned via Revise. The right way to fix this is in Julia itself, writing additional info to the package cache header. This will not land before Julia 1.13. - `include(mapexpr, file)` is well-suited to include the same file more than once with different `mapexpr`s. While it hasn't been tested, this seems unlikely to work for now, and the anticipated problems stem all the way back to Julia itself (again, issues that should be fixed in the package cache header). Package authors who want to use this in their packages can add a call to `Revise.parseall(@__MODULE__)` in their `__init__` function to ensure that the `mapexpr` files are parsed and tracked by Revise. Fixes #820, #634
|
That appears much less intrusive than what I started at timholy/CodeTracking.jl#142 (comment), that's great! IMHO the design remains somewhat less intuitive (treating the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjunction with
CodeTracking.MapExprFile, this allows Revise to trackchanges in files that are included with
include(mapexpr, file). ThisPR supports the implementation of revisions for such files, properly
applying the
mapexprtransformation to the included file'sexpressions.
What's missing:
initiate
mapexprwithout help. The problem is that Revise onlyparses files that get edited, but discovering that
file2.jlgetsincluded from
file1.jlvia amapexprrequires parsingfile1.jl,which may not have been edited and therefore never scanned via Revise.
The right way to fix this is in Julia itself, writing additional info
to the package cache header. This will not land before Julia 1.13.
include(mapexpr, file)is well-suited to include the same file morethan once with different
mapexprs. While it hasn't been tested, thisseems unlikely to work for now, and the anticipated problems stem all
the way back to Julia itself (again, issues that should be fixed in
the package cache header).
Package authors who want to use this in their packages can add a call to
Revise.parseall(@__MODULE__)in their__init__function toensure that the
mapexprfiles are parsed and tracked by Revise.Fixes #820, #634
Note this is built on #904 so the diff will be confusing unless you look at only the final commit.