Skip to content

Expose all of sentry features #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FlorianStasse
Copy link

Just like you did in timfish/sentry-tauri@c61e0bc, I disabled all of sentry features and exposed all of Sentry features through "minidump" features to allow users of this crate to disabled the default features from Sentry.

In my case, I need to do that if I want to include minidump but I cannot use the default features as openssl-sys (through native-tls feature of Sentry) will break my cross compilation to Android.

@FlorianStasse
Copy link
Author

FlorianStasse commented Jun 9, 2025

I think that minidump should be added to tauri-plugin-sentry with default-features = false, because if anyone enables sentry features using features from tauri-plugin-sentry, it will automatically enables them for minidump.

@FlorianStasse
Copy link
Author

@timfish Do you think you'll be able to review this ?

@timfish
Copy link
Owner

timfish commented Jul 6, 2025

To be honest, I'm thinking of setting the sentry dependency to "*" so I don't need to do a new release for every Sentry release. It'll just break when the APIs we are using change which shouldn't be very often.

Can you not set/override these features when you define Sentry as a dependency in your project?

@FlorianStasse
Copy link
Author

FlorianStasse commented Jul 9, 2025

I think that we cannot disable features enabled by dependencies. The only way it would work would be to set default-features=false in this crate, so that we can enable features as needed by depending directly on Sentry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants