Skip to content

bug/cannot run tumble window group by in superset #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Yibo-Chen13
Copy link

@Yibo-Chen13 Yibo-Chen13 commented Feb 20, 2025

Fix the error when determining whether a SQL statement is DDL/DML or not.

Add a sqlglot dialect of timeplus which is porting from clickhouse dialect

@Yibo-Chen13 Yibo-Chen13 reopened this Feb 20, 2025
@Yibo-Chen13 Yibo-Chen13 changed the base branch from main to timeplus February 20, 2025 07:28
@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch 14 times, most recently from df21608 to 5b06287 Compare February 21, 2025 07:59
@Yibo-Chen13 Yibo-Chen13 changed the title 3 cannot run tumble window group by in superset bug/cannot run tumble window group by in superset Feb 21, 2025
@Yibo-Chen13 Yibo-Chen13 linked an issue Feb 21, 2025 that may be closed by this pull request
@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch from 5b06287 to ef1b538 Compare February 21, 2025 08:04
@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch from ef1b538 to 81c2d04 Compare February 21, 2025 08:07
@Yibo-Chen13 Yibo-Chen13 marked this pull request as ready for review February 21, 2025 08:08

AGG_FUNCTIONS_SUFFIXES = [
"if",
"aary",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a typo?

@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch 4 times, most recently from e732420 to 72a998f Compare February 24, 2025 03:15
@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch 6 times, most recently from e88042e to ff394d6 Compare February 24, 2025 03:49
@Yibo-Chen13 Yibo-Chen13 force-pushed the 3-cannot-run-tumble-window-group-by-in-superset branch from ff394d6 to c9b7d9a Compare February 24, 2025 03:53
@Yibo-Chen13 Yibo-Chen13 merged commit 7c4acf1 into timeplus Feb 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run tumble window group by in superset
2 participants