Skip to content

Bugfix/9 should use show stream for get table names #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gangtao
Copy link

@gangtao gangtao commented Mar 4, 2025

There are couple of fix to support integration with llamaIndex

  1. should use text() to wrap queries
  2. add missing method get_columns in dialect
  3. set default schema (database) to 'default' when it is not specificed

there are more test need to be verified later for

  1. schema handling , and add schem in the uri
  2. verify following method: from_uri,get_single_table_info,get_table_columns,get_usable_table_names,insert_into_table,run_sql
  3. handle those engines introduce by timeplus - stream, external stream etc , now there will be warnings

@gangtao gangtao linked an issue Mar 4, 2025 that may be closed by this pull request
@gangtao gangtao self-assigned this Mar 5, 2025
@gangtao gangtao added the bug Something isn't working label Mar 5, 2025
@@ -10,7 +11,6 @@
from timeplus_connect.cc_sqlalchemy.sql.preparer import TpIdentifierPreparer
from timeplus_connect.driver.binding import quote_identifier, format_str


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add this empty line back. Minor thing but will make our future rebase/cherrypick a bit easier

@gangtao gangtao merged commit cba29d7 into timeplus Mar 5, 2025
14 checks passed
@jovezhong
Copy link

(Jove Github Bot) added it to the current sprint.

@jovezhong
Copy link

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should use SHOW STREAM for get_table_names
2 participants