-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Flexible palettes #6216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Flexible palettes #6216
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
c0e9b80
collect all default colour scales in one place
teunbrand d9d1305
wrap palettes
teunbrand 33ca805
document `palette` parameter
teunbrand 917353c
fix typo
teunbrand 0a78264
avoid recursive problems
teunbrand b32619a
only fall back when no explicit palette exists
teunbrand c0bb409
broaden test scope
teunbrand 532d501
add tests
teunbrand 3b0bc91
add news bullet
teunbrand ab44a18
merging a function element gives `new`
teunbrand 20de7be
update examples
teunbrand fb28e25
Merge branch 'main' into flexible_palettes
teunbrand e9d98c1
prefix scales pkg
teunbrand dd1247b
document / lol at my incompetence
teunbrand 0e465b0
Merge branch 'main' into flexible_palettes
teunbrand f7ce644
Fix #6289
teunbrand 3eded4f
Apply suggestions from code review
teunbrand a2ab6df
Merge branch 'main' into flexible_palettes
teunbrand 937d306
be more thorough with the parentheses
teunbrand ae867aa
Merge branch 'main' into flexible_palettes
teunbrand File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm being pedantic here but please make the same changes to the logic tests here and below :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah my bad, I should've spotted these!