Skip to content

geom_function(): x-axis title produced automatically where no data is added #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024
Merged

geom_function(): x-axis title produced automatically where no data is added #6047

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1f0c296
Produces x-axis title automatically when no data added. Fixes #5647.
phispu Aug 15, 2024
6f0a01b
Produces x-axis title automatically when no data added. Fixes #5647.
phispu Aug 15, 2024
9500771
Produces x-axis title automatically when no data added. Fixes #5647.
phispu Aug 15, 2024
0b5fb1f
Updated news to reflect bug fix from geom_smooth() to stat_function().
phispu Aug 15, 2024
622cba7
Merge branch 'main' into issue-5647-geom-function-nodata-xaxis-title
thomasp85 Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* Fixed bug in `geom_smooth()` so x-axis title now produced automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fixed bug in `geom_smooth()` so x-axis title now produced automatically
* Fixed bug in `stat_function()` so x-axis title now produced automatically

when no data added.
(@phispu, #5647).
* Missing values from discrete palettes are no longer translated
(@teunbrand, #5929).
* Fixed bug in `facet_grid(margins = TRUE)` when using expresssions
Expand Down
2 changes: 1 addition & 1 deletion R/stat-function.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ stat_function <- function(mapping = NULL, data = NULL,
#' @usage NULL
#' @export
StatFunction <- ggproto("StatFunction", Stat,
default_aes = aes(y = after_scale(y)),
default_aes = aes(x = NULL, y = after_scale(y)),

compute_group = function(data, scales, fun, xlim = NULL, n = 101, args = list()) {
if (is.null(scales$x)) {
Expand Down
Loading