show.legend for factor data for all levels, even when not observed
#6037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen no data for some levels exists. Fixes tidyverse#5869
teunbrand
requested changes
Aug 15, 2024
There was a problem hiding this comment.
Thanks for the pull request, I think this is a great start!
There are a few things that ideally should be worded slightly differently, please see the suggestion below.
Lastly, would you mind running devtools::document() to update the corresponding .Rd file as well?
If you'd like any help, please don't hesitate to stop Thomas or me!
edits from Tuen Co-authored-by: Teun van den Brand <49372158+teunbrand@users.noreply.github.com>
teunbrand
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added text to show how to add color to legends for all levels, even when no data for some levels exists.
Fixes #5869