-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Partial polar plots #5028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial polar plots #5028
Conversation
Sync branches
Is this still meaningful to get in or should we tackle it from anew after ggproto guides have been merged? |
I think the new ggproto guides don't interact with |
ok, I'll do a review next week |
Closing this PR in favour of #5334. |
This is my take on #4462, that adds an
end
argument tocoord_polar()
to allow partial polar plots.In brief:
end
is not used.Normally, the axis is placed in the upper part of the y-axis. If we have only the lower part of a circle, I had to reflect the break positions:
If 0 or π are not in the [start, end] interval, I have placed the axis in the x-direction. (Below also reflected because left instead of right).
If no integer multiple of 0.5π is in that interval, I can't appropriately place an axis anywhere. In that case, I've thrown a message with instructions.
Created on 2022-11-03 by the reprex package (v2.0.1)
After the guides are ported over to the ggproto system, we might consider a more complete solution for axis placement than this.